Allow Symfony 7.0 #17
Conversation
Tried to match dependencies from https://github.com/facile-it/mongodb-bundle/releases/tag/1.6.0
|
Before I spent time on getting these checks fixed, do you intent to support Symfony 7 @Jean85? |
|
I definitely want to support it! If you can, pleas continue with this, I'm also ok with bumping a couple of dependecies in this way. |
| test-composer-install: lock-symfony-3.4 lock-symfony-4.4 lock-symfony-5.0 lock-symfony-6.0 | ||
| test-composer-install: lock-symfony-5.4 lock-symfony-6.0 lock-symfony-7.0 |
There was a problem hiding this comment.
This is duplicated, it may not work correctly like this.
| "symfony/framework-bundle": "^5.0 || ^6.0 || ^7.0", | ||
| "symfony/messenger": "^5.0 || ^6.0 || ^7.0" |
There was a problem hiding this comment.
Are we dropping Symfony 4.4? If we do, we should bump up to 5.4, the other 5.x minors are not LTS.
| @@ -11,7 +11,7 @@ services: | |||
| depends_on: | |||
| - mongo | |||
| mongo: | |||
| image: mongo:3.4.2 | |||
| image: mongo:4.4 | |||
There was a problem hiding this comment.
Are we dropping support to Mongo below 4.4?
We need proper changelog details.
| - [ | ||
| '@Symfony\Component\Serializer\Normalizer\ArrayDenormalizer', | ||
| '@Symfony\Component\Serializer\Normalizer\DateTimeNormalizer', | ||
| '@Facile\MongoDbMessenger\Tests\End2End\App\SuppressDeprecationNormalizer' | ||
| '@Symfony\Component\Serializer\Normalizer\ObjectNormalizer' | ||
| ] | ||
| - ['@Symfony\Component\Serializer\Encoder\JsonEncoder'] | ||
|
|
||
| Symfony\Component\Serializer\Normalizer\ArrayDenormalizer: ~ | ||
| Symfony\Component\Serializer\Normalizer\DateTimeNormalizer: ~ | ||
| Facile\MongoDbMessenger\Tests\End2End\App\SuppressDeprecationNormalizer: ~ | ||
| Symfony\Component\Serializer\Normalizer\ObjectNormalizer: ~ | ||
| Symfony\Component\Serializer\Encoder\JsonEncoder: ~ |
There was a problem hiding this comment.
Since we dropped the specific normalizer, maybe we can drop the whole service definition? Or it's just temporary to see if we can solve the deprecations?
|
Hi @Jean85, thanks for your comments! Im actually struggling at lot to get the GH Actions to become all green! My suggestion is to bump Symfony versions to at least 5.4 (but please also consider bumping to 6.0) and drop support for PHP lower than 8.1? What do you think? |
|
@starred-gijs I'm continuing your work in #18 since I hadn't the permission to push here. I know it's a bit challenging, but I already had to grind my teeth on similar issues in the past, so I know what to do for now. Thanks for the help, I'll try to move it further! |
|
Thanks Jean85, your work is definitely appreciated! Let me know if I can help out with anything 👍 |
Tried to match dependencies from https://github.com/facile-it/mongodb-bundle/releases/tag/1.6.0
It needs some work to get all the checks working...